Registry-based unit test for custom effects

[bsalomon, 2012-08-02 22:01:44]

This only moves the gradient stages over to the new system. Others will come
later.

We weren't actually emitting custom stage code in the tests!!! The enabled bit
on StageDesc was being blown away after it was set.

This revealed some issues with the lighting stages. Also, I'm still getting a
compile failure with the LUT stage. So this can't be checked in yet. It appears
to be related (though prolly predates) the work Tom is doing on tex coords /
texture access. I'll investigate more tomorrow.

[bsalomon, 2012-08-03 13:57:25]

I think this sucker is ready for review. The test now passes.

[reed1, 2012-08-03 14:00:16]

lgtm

[TomH, 2012-08-03 14:12:36]

http://codereview.appspot.com/6447085/diff/4002/src/effects/gradients/SkRadia...
File src/effects/gradients/SkRadialGradient.cpp (right):

http://codereview.appspot.com/6447085/diff/4002/src/effects/gradients/SkRadia...
src/effects/gradients/SkRadialGradient.cpp:538: SkScalar* stops = stopsMaybe;
This same 5 lines of boilerplate has to happen every time RandomGradientParams()
is called. If we moved the allocation inside, could we return NULL or a RefCnt'd
array, and the the only boilerplate would be a SkSafeUnref()?

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (left):

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:188: if (!access.getTexture()) {
Wasn't this a necessary bug fix?

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:269: GrGLShaderVar& input = fGSInputs.back();
Not used?

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:275: GrGLShaderVar& output = fGSOutputs.back();
Not used?

[bsalomon, 2012-08-03 14:31:05]

http://codereview.appspot.com/6447085/diff/4002/src/effects/gradients/SkRadia...
File src/effects/gradients/SkRadialGradient.cpp (right):

http://codereview.appspot.com/6447085/diff/4002/src/effects/gradients/SkRadia...
src/effects/gradients/SkRadialGradient.cpp:538: SkScalar* stops = stopsMaybe;
On 2012/08/03 14:12:36, TomH wrote:
> This same 5 lines of boilerplate has to happen every time
RandomGradientParams()
> is called. If we moved the allocation inside, could we return NULL or a
RefCnt'd
> array, and the the only boilerplate would be a SkSafeUnref()?

Done.

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (left):

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:188: if (!access.getTexture()) {
On 2012/08/03 14:12:36, TomH wrote:
> Wasn't this a necessary bug fix?

Yes, it WAS. Now the dummy textures are used in the unit test. I'd rather not
have checks like that only matter in the unit test.

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

http://codereview.appspot.com/6447085/diff/4002/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:269: GrGLShaderVar& input = fGSInputs.back();
On 2012/08/03 14:12:36, TomH wrote:
> Not used?

Oops... I put these in to make the vars easily visible to in the debugger and
forgot to remove. Removed.

[TomH, 2012-08-03 14:33:02]

LGTM

[bsalomon, 2012-08-06 15:54:46]

Committed r4951