Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(275)

Issue 6447076: Fixed oversized SkRegion bound problem for complexclip_aa GM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by robertphillips
Modified:
11 years, 11 months ago
Reviewers:
reed, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In the case of entirely blank lines count_left_right_zeros was returning all the empty pixels on the left and 0 empty pixels on the right. In the complexclip_aa case there are other filled lines that bump the left zero count down but the right count remains pegged at 0. This resulted in an oversized bounding box.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added comments & an assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/core/SkAAClip.cpp View 1 5 chunks +15 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
robertphillips
11 years, 11 months ago (2012-08-01 15:58:53 UTC) #1
bsalomon
On 2012/08/01 15:58:53, robertphillips wrote: The SkGpuDevice change LGTM :)
11 years, 11 months ago (2012-08-01 17:35:34 UTC) #2
reed1
very good catch http://codereview.appspot.com/6447076/diff/1/src/core/SkAAClip.cpp File src/core/SkAAClip.cpp (right): http://codereview.appspot.com/6447076/diff/1/src/core/SkAAClip.cpp#newcode223 src/core/SkAAClip.cpp:223: // Document what we return, and ...
11 years, 11 months ago (2012-08-01 17:50:46 UTC) #3
robertphillips
http://codereview.appspot.com/6447076/diff/1/src/core/SkAAClip.cpp File src/core/SkAAClip.cpp (right): http://codereview.appspot.com/6447076/diff/1/src/core/SkAAClip.cpp#newcode223 src/core/SkAAClip.cpp:223: On 2012/08/01 17:50:46, reed1 wrote: > // Document what ...
11 years, 11 months ago (2012-08-01 18:22:25 UTC) #4
robertphillips
11 years, 11 months ago (2012-08-02 12:45:41 UTC) #5
committed as r4906
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b