Issue 6447063: Added test to ensure getConservativeBounds' result is clamped to render target

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6447063: Added test to ensure getConservativeBounds' result is clamped to render target (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by robertphillips

Modified:
12 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This test would've caught the issue that blocked r4804's DEPS roll. See http://codereview.appspot.com/6442063/ (Fix for clip assert in Chrome tests) for more information.

Patch Set 1 #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
	M	tests/ClipCacheTest.cpp	View		2 chunks	+70 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM http://codereview.appspot.com/6447063/diff/1/tests/ClipCacheTest.cpp File tests/ClipCacheTest.cpp (right): http://codereview.appspot.com/6447063/diff/1/tests/ClipCacheTest.cpp#newcode43 tests/ClipCacheTest.cpp:43: static const int gXSize = 100; kXSize

12 years, 4 months ago (2012-07-30 19:13:33 UTC) #2

robertphillips

12 years, 4 months ago (2012-07-31 11:48:04 UTC) #3

committed as r4846

http://codereview.appspot.com/6447063/diff/1/tests/ClipCacheTest.cpp
File tests/ClipCacheTest.cpp (right):

http://codereview.appspot.com/6447063/diff/1/tests/ClipCacheTest.cpp#newcode43
tests/ClipCacheTest.cpp:43: static const int gXSize = 100;
On 2012/07/30 19:13:33, bsalomon wrote:
> kXSize

Done.

Expand All Messages | Collapse All Messages