Properly implement fromproperty markup handing in the pdftitle header field

Properly implement fromproperty markup handing in the pdftitle header field

The pdftitle header field is obtained by trying to convert the markup into a pure string.
Fromproperty markups need to be handled specially, since we have to mimick the header field
lookup in the conversion function... Thus we have to pass the header block to the
markup->string function and extract the header property values for fromproperty markups.

[dak, 2012-07-28 10:00:53]

http://codereview.appspot.com/6447052/diff/1/scm/markup.scm
File scm/markup.scm (right):

http://codereview.appspot.com/6447052/diff/1/scm/markup.scm#newcode82
scm/markup.scm:82: (define-public (markup->string props m)
This changes the interface of a public function in an incompatible manner.

This will break existing code like in
<URL:http://lists.gnu.org/archive/html/lilypond-user/2012-04/msg00531.html>.

Please try using an optional argument "props" instead, retaining the old
behavior if it is not given.

[dak, 2012-08-05 22:44:47]

http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm
File scm/markup.scm (right):

http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109
scm/markup.scm:109: (define (markup-cons->string-cons c props)
"props" seems like a total misnomer: that is usually used for a list of alists,
while it here is a list of modules/scopes.

[reinhold_kainhofer.com, 2012-08-05 23:26:46]

On 2012-08-06 00:44, dak@gnu.org wrote:
>
> http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm
> File scm/markup.scm (right):
>
> http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109
> scm/markup.scm:109: (define (markup-cons->string-cons c props)
> "props" seems like a total misnomer: that is usually used for a list of
> alists, while it here is a list of modules/scopes.

Do you have any better suggestion?

Thanks,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
  * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
  * http://www.fam.tuwien.ac.at/, DVR: 0005886
  * LilyPond, Music typesetting, http://www.lilypond.org

[dak, 2012-08-05 23:42:25]

On 2012/08/05 23:26:46, reinhold_kainhofer.com wrote:
> On 2012-08-06 00:44, mailto:dak@gnu.org wrote:
> >
> > http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm
> > File scm/markup.scm (right):
> >
> > http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109
> > scm/markup.scm:109: (define (markup-cons->string-cons c props)
> > "props" seems like a total misnomer: that is usually used for a list of
> > alists, while it here is a list of modules/scopes.
> 
> Do you have any better suggestion?

Anything wrong with "scopes"?  You actually use it as function argument, just
not in the let*.