Issue 6447043: Doc: fixed 3/4 snippets in German NR (issue 2401)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6447043: Doc: fixed 3/4 snippets in German NR (issue 2401)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by fred1995

Modified:
11 years, 8 months ago

Reviewers:
Graham Percival, frederic.bron

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Doc: fixed 3/4 snippets in German NR (issue 2401) also fixed wrong comment in same snippet (all translations)

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	Documentation/de/notation/rhythms.itely	View	2 chunks	+6 lines, -8 lines	1 comment	Download
M	Documentation/es/notation/rhythms.itely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/fr/notation/rhythms.itely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/ja/notation/rhythms.itely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/notation/rhythms.itely	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Graham Percival

LGTM http://codereview.appspot.com/6447043/diff/1/Documentation/de/notation/rhythms.itely File Documentation/de/notation/rhythms.itely (right): http://codereview.appspot.com/6447043/diff/1/Documentation/de/notation/rhythms.itely#newcode2271 Documentation/de/notation/rhythms.itely:2271: % by default we beam in (6) due ...

11 years, 8 months ago (2012-07-27 11:51:42 UTC) #1

frederic.bron_m4x.org

11 years, 8 months ago (2012-07-27 18:45:31 UTC) #2

>
http://codereview.appspot.com/6447043/diff/1/Documentation/de/notation/rhythm...
> Documentation/de/notation/rhythms.itely:2271: % by default we beam in
> (6) due to beamExceptions
> are you sure you don't want German comments here?

Only Japanese has japanese comments, all other languages have comments
in English. German had it already in English.
Therefore I prefer to fix what I can fix rather than doing nothing.
German speaking translators can change that later if they want but I
suspect it is a larger issue than just 3/4 snippet.

Frédéric

Expand All Messages | Collapse All Messages