Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(506)

Issue 6446160: Doc: Bar_engraver is required for system-start clefs (2694) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Trevor Daniels
Modified:
11 years, 8 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: Bar_engraver is required for system-start clefs (2694) Add sentence to doc string of Bar_engraver

Patch Set 1 #

Total comments: 1

Patch Set 2 : Avoid compound adjective #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M lily/bar-engraver.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
Trevor Daniels
This minor change hardly needs the full review machinery, especially as I've checked it with ...
11 years, 8 months ago (2012-08-20 07:36:44 UTC) #1
dak
http://codereview.appspot.com/6446160/diff/1/lily/bar-engraver.cc File lily/bar-engraver.cc (right): http://codereview.appspot.com/6446160/diff/1/lily/bar-engraver.cc#newcode119 lily/bar-engraver.cc:119: " is required to trigger the creation of system-start ...
11 years, 8 months ago (2012-08-20 08:13:32 UTC) #2
Trevor Daniels
On 2012/08/20 08:13:32, dak wrote: > or it is plain English, in which case it ...
11 years, 8 months ago (2012-08-20 09:32:18 UTC) #3
dak
On 2012/08/20 09:32:18, Trevor Daniels wrote: > On 2012/08/20 08:13:32, dak wrote: > > > ...
11 years, 8 months ago (2012-08-20 09:50:33 UTC) #4
Graham Percival
LGTM
11 years, 8 months ago (2012-08-21 11:53:45 UTC) #5
Trevor Daniels
11 years, 8 months ago (2012-08-24 11:27:45 UTC) #6
Pushed to staging as
bd73258c56a29a0e585c9653a2ba941390bd19d9
Closing
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b