Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(734)

Issue 6446150: Remove flushes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by bsalomon
Modified:
11 years, 10 months ago
Reviewers:
robertphillips, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Dependent upon http://codereview.appspot.com/6465061/ landing first

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Total comments: 1

Patch Set 4 : Remove assertions #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M include/gpu/GrContext.h View 1 2 3 2 chunks +3 lines, -4 lines 1 comment Download
M src/gpu/GrContext.cpp View 1 2 3 15 chunks +35 lines, -32 lines 0 comments Download

Messages

Total messages: 5
bsalomon
Removes some unnecessary GrContext flush() calls. Also, makes morphology and convolution play nice with the ...
11 years, 10 months ago (2012-08-16 21:42:35 UTC) #1
bsalomon
I removed the assertions after confirming with Rob that they are incorrect.
11 years, 10 months ago (2012-08-17 13:40:39 UTC) #2
robertphillips
LGTM
11 years, 10 months ago (2012-08-17 13:50:04 UTC) #3
TomH
LGTM http://codereview.appspot.com/6446150/diff/1003/include/gpu/GrContext.h File include/gpu/GrContext.h (right): http://codereview.appspot.com/6446150/diff/1003/include/gpu/GrContext.h#newcode781 include/gpu/GrContext.h:781: // Sets the paint and returns the target ...
11 years, 10 months ago (2012-08-17 13:52:13 UTC) #4
bsalomon
11 years, 10 months ago (2012-08-17 14:07:06 UTC) #5
Landed in r5150.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b