Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(498)

Issue 6446108: Added method of getting top genID from SkClipStack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by robertphillips
Modified:
11 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL actually has two methods of getting the top genID from SkClipStack. One is through SkClipStack::getTopmostGenID(). The other is using the fGenID field of the Clip object returned by the iterator. The method that actually implements that technique lives in an as yet undelivered file and is: int32_t get_topmost_genID(const SkClipStack& clip) { SkClipStack::Iter iter(clip, SkClipStack::Iter::kTop_IterStart); const SkClipStack::Iter::Clip* temp = iter.prev(); if (NULL == temp) { return SkClipStack::kInvalidGenID; } return temp->fGenID; }

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M include/core/SkClipStack.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkClipStack.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
11 years, 10 months ago (2012-08-09 17:28:27 UTC) #1
bsalomon
On 2012/08/09 17:28:27, robertphillips wrote: LGTM
11 years, 10 months ago (2012-08-09 18:00:19 UTC) #2
robertphillips
11 years, 10 months ago (2012-08-09 18:11:10 UTC) #3
committed as r5034
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b