code review 6446105: cmd/go: set GOARM automatically on linux/arm

cmd/go: set GOARM automatically on linux/arm

This proposal gives the go command the ability to export the correct GOARM value by inspecting the cpu features of the running system. This can be overridden by exporting GOARM manually.

GOARM is still required for ARMv5 systems to correctly execute ./make.bash.

[dave_cheney.net, 2012-08-09 09:38:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2012-08-09 09:46:35]

LGTM; +rsc

[dave_cheney.net, 2012-08-09 12:28:51]

PTAL. Thanks to Roger Peppe for the /proc/cpuinfo parsing improvements.

[minux1, 2012-08-09 12:36:58]

http://codereview.appspot.com/6446105/diff/9002/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6446105/diff/9002/src/cmd/go/main.go#newcode598
src/cmd/go/main.go:598: }
do you want to break here?

[dave_cheney.net, 2012-08-09 12:48:06]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-08-09 19:42:27]

NOT LGTM

I will reply to your mail thread.

[dave_cheney.net, 2012-08-09 23:49:18]

*** Abandoned ***