Issue 6446091: Reference widget

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446091: Reference widget (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by xiaq

Modified:
12 years, 3 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Patch Set 2 : remove OrderedDict dependency, add validator #

Patch Set 3 : fix ValidReference #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	MoinMoin/forms.py	View	1 2	2 chunks	+46 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

xiaq

This is the Reference widget stripped from the old big metadata editor patch set. ThomasWaldmann ...

12 years, 3 months ago (2012-08-06 07:10:39 UTC) #1

Reimar Bauer

some comments http://codereview.appspot.com/6446091/diff/2001/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6446091/diff/2001/MoinMoin/forms.py#newcode129 MoinMoin/forms.py:129: choices = OrderedDict([(rev.meta[ITEMID], rev.meta[NAME]) for rev in ...

12 years, 3 months ago (2012-08-08 07:40:33 UTC) #2

xiaq

http://codereview.appspot.com/6446091/diff/2001/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6446091/diff/2001/MoinMoin/forms.py#newcode129 MoinMoin/forms.py:129: choices = OrderedDict([(rev.meta[ITEMID], rev.meta[NAME]) for rev in revs]) On ...

12 years, 3 months ago (2012-08-08 07:53:30 UTC) #3

xiaq

12 years, 3 months ago (2012-08-12 10:30:53 UTC) #5

http://codereview.appspot.com/6446091/diff/9002/MoinMoin/forms.py
File MoinMoin/forms.py (right):

http://codereview.appspot.com/6446091/diff/9002/MoinMoin/forms.py#newcode158
MoinMoin/forms.py:158: if element.value not in element.valid_values:
ignore delta above this line, it's due to rebasing.

Expand All Messages | Collapse All Messages