Fixing test failures with Java 7

Created to fix http://code.google.com/p/google-http-java-client/issues/detail?id=142 : Test failures with Java 7.

For more context please see here:
http://stackoverflow.com/questions/11688312/classcastexception-when-upgrading-from-java6-to-java7-due-to-missing-genericarra

[yanivi, 2012-07-30 17:24:41]

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
File google-http-client/src/test/java/com/google/api/client/util/TypesTest.java
(right):

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:158:
public Vector<T[]> arr;
I'd still like to test Vector<Integer[]> also.  Can you please add a field and
assert for that?

To deal with Java 5 vs Java 7 issue, I recommend using
Types.getArrayComponentType().

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:196:
public HashMap<String, T[]> arr;
same here

[rmistry, 2012-07-30 18:31:05]

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
File google-http-client/src/test/java/com/google/api/client/util/TypesTest.java
(right):

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:158:
public Vector<T[]> arr;
On 2012/07/30 17:24:41, yanivi wrote:
> I'd still like to test Vector<Integer[]> also.  Can you please add a field and
> assert for that?
> 
> To deal with Java 5 vs Java 7 issue, I recommend using
> Types.getArrayComponentType().

I think Done. Looks strange to have to do
Types.getArrayComponentType(Types.getIterableParameter(..))) but this is what
worked in both java5 and java7.

http://codereview.appspot.com/6446056/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:196:
public HashMap<String, T[]> arr;
On 2012/07/30 17:24:41, yanivi wrote:
> same here

Done.

[yanivi, 2012-07-30 19:46:52]

LGTM

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
File google-http-client/src/test/java/com/google/api/client/util/TypesTest.java
(right):

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:182:
.getGenericComponentType().toString());
more reliable to use getName() instead of toString()

simlarly below

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:183:
assertEquals(Integer.class, Types.getArrayComponentType(
[optional] please move this assertEquals one statement up to make the diff
easier to understand

similarly below

[rmistry, 2012-07-31 14:53:01]

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
File google-http-client/src/test/java/com/google/api/client/util/TypesTest.java
(right):

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:182:
.getGenericComponentType().toString());
On 2012/07/30 19:46:52, yanivi wrote:
> more reliable to use getName() instead of toString()
> 
> simlarly below

getGenericComponentType() returns the interface Type which does not have a
getName() method.

http://codereview.appspot.com/6446056/diff/3/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/util/TypesTest.java:183:
assertEquals(Integer.class, Types.getArrayComponentType(
On 2012/07/30 19:46:52, yanivi wrote:
> [optional] please move this assertEquals one statement up to make the diff
> easier to understand
> 
> similarly below

Done.

[rmistry, 2012-07-31 14:53:47]

Submitting..