Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1539)

Issue 6445082: code review 6445082: pprof: make it work on windows again (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by brainman
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

pprof: make it work on windows again - pprof is a perl script, so go command should invoke perl instead of trying to run pprof directly; - pprof should use "go tool nm" unconditionally on windows, no one else can extract symbols from Go program; - pprof should use "go tool nm" instead of "6nm". Fixes issue 3879.

Patch Set 1 #

Patch Set 2 : diff -r a718fd96683c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a718fd96683c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 365d02e0927c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M misc/pprof View 1 2 chunks +8 lines, -10 lines 0 comments Download
M src/cmd/go/tool.go View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-08-07 02:31:20 UTC) #1
r
LGTM
12 years, 9 months ago (2012-08-17 18:26:24 UTC) #2
brainman
12 years, 9 months ago (2012-08-18 07:03:41 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=7c5f4dad8fae ***

pprof: make it work on windows again

- pprof is a perl script, so go command should invoke
  perl instead of trying to run pprof directly;
- pprof should use "go tool nm" unconditionally on windows,
  no one else can extract symbols from Go program;
- pprof should use "go tool nm" instead of "6nm".

Fixes issue 3879.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6445082
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b