Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 6445053: Issue 1650: merge multiple header specifications. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by dak
Modified:
11 years, 8 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Issue 1650: merge multiple header specifications. Books get initialized from $defaultheader, this is what toplevel \header will set, and scores and bookparts are initialized empty so that they will end up combined with their respective (possibly implicit) books.

Patch Set 1 #

Patch Set 2 : Add regtests from Reinhold, initialize \score \header to empty. #

Total comments: 2

Patch Set 3 : Rework the regtests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -17 lines) Patch
A input/regression/header-book-multiple.ly View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A input/regression/header-book-multiplescores.ly View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A input/regression/header-bookpart-multiple.ly View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/header-score-multiple.ly View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A input/regression/header-toplevel-multiple.ly View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M lily/parser.yy View 1 7 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 4
Graham Percival
LGTM, and I really like the comments in the regtests. In a few instances they ...
11 years, 8 months ago (2012-07-30 14:35:05 UTC) #1
dak
On 2012/07/30 14:35:05, Graham Percival wrote: > LGTM, and I really like the comments in ...
11 years, 8 months ago (2012-07-30 14:43:46 UTC) #2
Reinhold
LGTM, seems to work correctly on all my (reg)tests. I actually like David's idea of ...
11 years, 8 months ago (2012-07-30 15:06:02 UTC) #3
Graham Percival
11 years, 8 months ago (2012-07-30 15:27:19 UTC) #4
On Mon, Jul 30, 2012 at 02:43:46PM +0000, dak@gnu.org wrote:
> "Incorrect title (from book)"
> "Correct title (from bookpart)"
> and similar.  That way, it is easier to see whether the results are as
> expected.

sure, that sounds good.

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b