Issue 6443117: Ticket

Issue 6443117: Ticket (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by xiaq

Modified:
12 years, 2 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Patch Set 2 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -14 lines)			Patch
M	MoinMoin/items/__init__.py	View		3 chunks	+16 lines, -14 lines	0 comments	Download
A	MoinMoin/items/ticket.py	View	1	1 chunk	+144 lines, -0 lines	0 comments	Download
M	MoinMoin/storage/middleware/indexing.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	MoinMoin/templates/ticket.html	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Reimar Bauer

some comments http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newcode31 MoinMoin/items/ticket.py:31: parameter below this line definition are also ...

12 years, 3 months ago (2012-08-13 05:43:54 UTC) #1

ThomasJWaldmann

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newcode30 MoinMoin/items/ticket.py:30: ITEMTYPE_TICKET = u'ticket' hmm, do we have a MoinMoin.constants ...

12 years, 3 months ago (2012-08-13 06:59:53 UTC) #2

xiaq

12 years, 3 months ago (2012-08-13 16:35:00 UTC) #3

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py
File MoinMoin/items/ticket.py (right):

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:30: ITEMTYPE_TICKET = u'ticket'
On 2012/08/13 06:59:53, ThomasJWaldmann wrote:
> hmm, do we have a MoinMoin.constants module for these?

not yet. :(

that can be done a bit later.

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:31: 
On 2012/08/13 05:43:54, Reimar Bauer wrote:
> parameter below this line definition are also global.
> should they uppercase written?

makes sense.

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:45: # tags = Tags.using(optional=True)
On 2012/08/13 06:59:53, ThomasJWaldmann wrote:
> why commented?

so i uncomment it...

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:83: return u'''{{{#!wiki tip
On 2012/08/13 05:43:54, Reimar Bauer wrote:
> there should an option for wiki format to select. that also then shows to the
> user which format he should type. Make it selectable for some markups default
> wiki, rst 
> At least tell on the ui it is wiki markup
> 
> as long we don't have the comment system by spy we should at least use more
> curly brackets e.g. 
> {{{{{{#!wiki tip
> 
> that allows users to use plain by {{{ inside the ticket

ok, though it still feels as broken as before. :)

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:113: CONTENTTYPE: 'text/x.moin.wiki;charset=utf-8',
On 2012/08/13 06:59:53, ThomasJWaldmann wrote:
> there might be a constant for this

it's in constants/contenttypes.py but with current structure it's nontrivial to
extract this constant...

http://codereview.appspot.com/6443117/diff/8001/MoinMoin/items/ticket.py#newc...
MoinMoin/items/ticket.py:119: data =
self.content.data_storage_to_internal(self.content.data)
On 2012/08/13 06:59:53, ThomasJWaldmann wrote:
> maybe the NonExistingContent could have a .data attr/property that is u''?

sounds good, will look at this later.

Expand All Messages | Collapse All Messages