Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(642)

Issue 6443116: Doc: standardise level 5 headings (2730) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Trevor Daniels
Modified:
11 years, 8 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: standardise level 5 headings (2730) - add subsubheadingitalic macro for use as level 5 heading - update CG to document its use - amend first 2 sections of Chapter 1 of NR

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change to subsubsubheading as Graham suggested; apply to all Chapter 1 of NR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M Documentation/common-macros.itexi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Documentation/contributor/doc-work.itexi View 1 2 chunks +24 lines, -7 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
John Mandereau
I haven't built (well, a "make all" is going to test this change with "makeinfo ...
11 years, 8 months ago (2012-08-13 08:31:48 UTC) #1
Graham Percival
LGTM other than one slightly quibble. http://codereview.appspot.com/6443116/diff/1/Documentation/common-macros.itexi File Documentation/common-macros.itexi (right): http://codereview.appspot.com/6443116/diff/1/Documentation/common-macros.itexi#newcode81 Documentation/common-macros.itexi:81: @macro subsubheadingitalic {TEXT} ...
11 years, 8 months ago (2012-08-13 08:46:10 UTC) #2
Trevor Daniels
On 2012/08/13 08:46:10, Graham Percival wrote: > How do you feel about @subsubsubheading {TEXT}? Perfectly ...
11 years, 8 months ago (2012-08-13 09:23:43 UTC) #3
Graham Percival
LGTM
11 years, 8 months ago (2012-08-14 18:59:54 UTC) #4
Trevor Daniels
11 years, 8 months ago (2012-08-17 07:54:51 UTC) #5
Pushed to staging as
229e78d781e24469d65e47244fb6eb161be84621
Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b