Issue 6443113: replace src/mobility usage of RandomVariable with RandomVariableStream

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6443113: replace src/mobility usage of RandomVariable with RandomVariableStream

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Tom Henderson

Modified:
12 years, 9 months ago

Reviewers:
Pavel Boyko

Visibility:
Public.

More Reviews

Description

replace src/mobility usage of RandomVariable with RandomVariableStream Patch 1 just changes the underlying RV implementations Patch 2 applies on patch 1 and adds AssignStreams support

Patch Set 1 #

Patch Set 2 : add AssignStreams #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+274 lines, -36 lines)			Patch
M	examples/routing/manet-routing-compare.cc	View	1	1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/buildings/helper/building-position-allocator.h	View	1	5 chunks	+7 lines, -0 lines	0 comments	Download
M	src/buildings/helper/building-position-allocator.cc	View	1	12 chunks	+36 lines, -20 lines	0 comments	Download
M	src/mobility/doc/mobility.rst	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/mobility/helper/mobility-helper.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/mobility/helper/mobility-helper.cc	View	1	1 chunk	+17 lines, -1 line	0 comments	Download
M	src/mobility/model/gauss-markov-mobility-model.h	View	1	2 chunks	+10 lines, -9 lines	0 comments	Download
M	src/mobility/model/gauss-markov-mobility-model.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/mobility/model/mobility-model.h	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/mobility/model/mobility-model.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/mobility/model/position-allocator.h	View	1	7 chunks	+17 lines, -0 lines	0 comments	Download
M	src/mobility/model/position-allocator.cc	View	1	6 chunks	+40 lines, -1 line	0 comments	Download
M	src/mobility/model/random-direction-2d-mobility-model.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mobility/model/random-direction-2d-mobility-model.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/mobility/model/random-walk-2d-mobility-model.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mobility/model/random-walk-2d-mobility-model.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/mobility/model/random-waypoint-mobility-model.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mobility/model/random-waypoint-mobility-model.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/mobility/model/steady-state-random-waypoint-mobility-model.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mobility/model/steady-state-random-waypoint-mobility-model.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Pavel Boyko

12 years, 9 months ago (2012-08-15 07:21:04 UTC) #1

The code looks ugly but pretty straightforward and correct. Please push.

Expand All Messages | Collapse All Messages