Changes make test to allow output to be reviewed in a browser

As the title says, really.  To date, running make test creates only .ps files which it's difficult to check.  This changes the output to .png, which means that collated-files.html can be opened by a browser and the reg tests checked.

[PhilEHolmes, 2012-07-31 20:55:06]

Please review.

[Graham Percival, 2012-07-31 21:04:24]

I'm extremely cautious about _removing_ the ps output, since that might break
the regtest comparisons in GUB.  Have you / could you test this?

I'd be much happier if this patch created pngs *in addition* to ps.  I don't
think we need to worry about making the process 10% or even 20% slower.

http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make
File make/lysdoc-vars.make (left):

http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make#oldcode10
make/lysdoc-vars.make:10: LILYPOND_BOOK_FLAGS += --use-source-file-names
why?

[John Mandereau, 2012-08-01 16:32:29]

I have nothing to say other than seconding comments from Graham.

http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make
File make/lysdoc-vars.make (left):

http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make#oldcode10
make/lysdoc-vars.make:10: LILYPOND_BOOK_FLAGS += --use-source-file-names
On 2012/07/31 21:04:24, Graham Percival wrote:
> why?

I second this reaction.  BTW I hope regtest comparison between releases relies
on "make doc" output and not on "make test"; if so this change is acceptable,
otherwise it may break regtest comparison.

[email_philholmes.net, 2012-08-01 16:45:54]

----- Original Message ----- 
From: <john.mandereau@gmail.com>
To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Wednesday, August 01, 2012 5:32 PM
Subject: Re: Changes make test to allow output to be reviewed in a browser 
(issue 6442068)


>I have nothing to say other than seconding comments from Graham.
>
>
> http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make
> File make/lysdoc-vars.make (left):
>
> http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make#oldcode10
> make/lysdoc-vars.make:10: LILYPOND_BOOK_FLAGS += --use-source-file-names
> On 2012/07/31 21:04:24, Graham Percival wrote:
>> why?
>
> I second this reaction.  BTW I hope regtest comparison between releases
> relies on "make doc" output and not on "make test"; if so this change is
> acceptable, otherwise it may break regtest comparison.
>
> http://codereview.appspot.com/6442068/

The line was deleted in that patch, since no PNGs were actually generated 
with the flag present.

That said, Graham was right and this does break regtest comparison, but not 
in a way that I currently understand.  This is true even with 
formats=png,ps.  I'm currently looking at what's going on and will certainly 
not propose anything else unless make check, etc., work.

--
Phil Holmes