Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(746)

Issue 6442063: Fix for clip assert in Chrome tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When creating r4798, I overlooked a difference in GrClip and SkClipStack's behaviors. When a clip reduces to a single rect, GrClip ignores the bounding box passed to it from the SkClipStack and instead uses the reduced rect. A problem arises because the reduced rect is never cropped to the render target's bound. This CL adds another crop to the GrClipData::getConservativeBound helper function.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/gpu/GrClip.cpp View 1 chunk +14 lines, -1 line 1 comment Download

Messages

Total messages: 4
robertphillips
12 years, 1 month ago (2012-07-30 16:59:02 UTC) #1
reed1
http://codereview.appspot.com/6442063/diff/1/src/gpu/GrClip.cpp File src/gpu/GrClip.cpp (right): http://codereview.appspot.com/6442063/diff/1/src/gpu/GrClip.cpp#newcode263 src/gpu/GrClip.cpp:263: // was never trimmed to the render target's bounds. ...
12 years, 1 month ago (2012-07-30 17:02:22 UTC) #2
bsalomon
I confirmed that it fixes the DRT crash. LGTM.
12 years, 1 month ago (2012-07-30 17:06:35 UTC) #3
robertphillips
12 years, 1 month ago (2012-07-30 17:11:52 UTC) #4
committed as r4834.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b