Unit tests for Blog itemtype.

Unit tests for Blog itemtype.

[Reimar Bauer, 2012-08-17 07:34:39]

some comments

http://codereview.appspot.com/6441151/diff/1/MoinMoin/items/_tests/test_Blog.py
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/1/MoinMoin/items/_tests/test_Blog....
MoinMoin/items/_tests/test_Blog.py:33: name = u'NewBlogItem'
you could split that in some methods. It is a bit longish to have that all here.

e.g. separate tests for 
create
modify
acl test 

you also could have a setup_method

content_acl state?

http://codereview.appspot.com/6441151/diff/1/MoinMoin/items/_tests/test_Blog....
MoinMoin/items/_tests/test_Blog.py:79: entry_meta[ACL] = "TrustedUser:read"
u"..."

[Reimar Bauer, 2012-08-17 15:46:06]

Better

I have  currently a tablet only.

Check in General also that  the Test are  reabable by  names 
too

I look at Them at home again

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:89: def test_do_show_acl(self):
that Name is misleading

[ThomasJWaldmann, 2012-08-17 18:01:12]

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:30: class TestBlog(TestView):
please have 2 empty lines between toplevel definitions like classes, functions.

[spy, 2012-08-17 19:18:50]

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:30: class TestBlog(TestView):
On 2012/08/17 18:01:12, ThomasJWaldmann wrote:
> please have 2 empty lines between toplevel definitions like classes,
functions.

okay.

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:89: def test_do_show_acl(self):
On 2012/08/17 15:46:06, Reimar Bauer wrote:
> that Name is misleading 

renamed to test_entries_acls

[Reimar Bauer, 2012-08-17 20:49:29]

a little bit more

try also to use common parameter names that makes reading tests later easier.

common in the way you used them in the routine you test.

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:72: entry_meta[PTIME] = 1000 # unix timestamp
for this kind of update one could have a helper function

http://codereview.appspot.com/6441151/diff/9002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:101: update_item(self.entries[0]['name'],
entry_meta, self.entries[0]['data'])
the helper function could be used here too

[Reimar Bauer, 2012-08-17 22:32:15]

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:109: ordered_data = [self.data,
here you set the order manually. where do you get that from the program, why not
calling that method?

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:148: self._test_view(self.entry_name,
data_tokens=data_tokens)
add the coverage_modules = ['the module which is covered'] line and check what
is not covered

[spy, 2012-08-17 23:17:00]

some replies

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:109: ordered_data = [self.data,
On 2012/08/17 22:32:15, Reimar Bauer wrote:
> here you set the order manually. where do you get that from the program, why
not
> calling that method?
> 

line 102-105: I publish three entries with specific PTIMEs.
line 112: I compile a regex from this manually ordered list and then apply the
regex to the returned blog html page to check the right sorting order of its
entries.

http://codereview.appspot.com/6441151/diff/1005/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:148: self._test_view(self.entry_name,
data_tokens=data_tokens)
On 2012/08/17 22:32:15, Reimar Bauer wrote:
> add the coverage_modules = ['the module which is covered'] line and check what
> is not covered

py.test does not provide "-c" arg anymore, doesn't it? what does
"coverage_modules" stand for?
I've installed http://pypi.python.org/pypi/pytest-cov/
Pretty funny tool, will play with it tomorrow.

[ThomasJWaldmann, 2012-08-18 16:34:16]

http://codereview.appspot.com/6441151/diff/8002/MoinMoin/items/_tests/test_Bl...
File MoinMoin/items/_tests/test_Blog.py (right):

http://codereview.appspot.com/6441151/diff/8002/MoinMoin/items/_tests/test_Bl...
MoinMoin/items/_tests/test_Blog.py:48: if acl:
if acl is not None: