Add support for GCE service accounts

[aiuto, 2012-08-09 13:54:47]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode34
oauth2client/gce.py:34: META =
'http://metadata/0.1/meta-data/service-accounts/default/acquire{?scope}'
'default' could be a parameter.

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode37
oauth2client/gce.py:37: class AppAssertionCredentials(AssertionCredentials):
I think we might be better off with ComputeEngineAssertionCredentials.

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode40
oauth2client/gce.py:40: This object will allow an Compute Engine instance to
identify itself to
allow a Compute ...

[jcgregorio_google, 2012-08-09 14:37:39]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode34
oauth2client/gce.py:34: META =
'http://metadata/0.1/meta-data/service-accounts/default/acquire{?scope}'
It could be, but we can always add that in the future. The reason I don't want
to add it now is because I don't know what non-default values would look like,
would they be project ids, or email addresses, or maybe private key finger
prints...

On 2012/08/09 13:54:47, aiuto wrote:
> 'default' could be a parameter.

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode37
oauth2client/gce.py:37: class AppAssertionCredentials(AssertionCredentials):
Actually this already sits in the 'gce' module, how about simply
AssertionCredentials?

On 2012/08/09 13:54:47, aiuto wrote:
> I think we might be better off with ComputeEngineAssertionCredentials.

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode40
oauth2client/gce.py:40: This object will allow an Compute Engine instance to
identify itself to
On 2012/08/09 13:54:47, aiuto wrote:
> allow a Compute ...

Done.

[Ali Afshar, 2012-08-09 14:41:41]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode84
oauth2client/gce.py:84: response, content = http_request(uri)
Can this refresh use the existing oauth2 client somehow?

[jcgregorio_google, 2012-08-09 14:44:36]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode84
oauth2client/gce.py:84: response, content = http_request(uri)
Sorry, I don't understand.This _refresh() will get called as a matter of course
when a Credentials needs refreshing. See
http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...


On 2012/08/09 14:41:41, Ali Afshar wrote:
> Can this refresh use the existing oauth2 client somehow?

[Ali Afshar, 2012-08-09 14:53:40]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode84
oauth2client/gce.py:84: response, content = http_request(uri)
Right, is there no common code with a standard Credentials for performing this
refresh?

On 2012/08/09 14:44:36, jcgregorio_google wrote:
> Sorry, I don't understand.This _refresh() will get called as a matter of
course
> when a Credentials needs refreshing. See
>
http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...
> 
> 
> On 2012/08/09 14:41:41, Ali Afshar wrote:
> > Can this refresh use the existing oauth2 client somehow?
>

[jcgregorio_google, 2012-08-09 14:59:37]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode84
oauth2client/gce.py:84: response, content = http_request(uri)
_refresh() is defined in the base OAuth2Credentials object and over-ridden here:


http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...

On 2012/08/09 14:53:40, Ali Afshar wrote:
> Right, is there no common code with a standard Credentials for performing this
> refresh?
> 
> On 2012/08/09 14:44:36, jcgregorio_google wrote:
> > Sorry, I don't understand.This _refresh() will get called as a matter of
> course
> > when a Credentials needs refreshing. See
> >
>
http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...
> > 
> > 
> > On 2012/08/09 14:41:41, Ali Afshar wrote:
> > > Can this refresh use the existing oauth2 client somehow?
> > 
>

[aiuto, 2012-08-09 15:07:57]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode37
oauth2client/gce.py:37: class AppAssertionCredentials(AssertionCredentials):
On 2012/08/09 14:37:40, jcgregorio_google wrote:
> Actually this already sits in the 'gce' module, how about simply
> AssertionCredentials?

Won't you have a type name clash?
  class AssertionCredentials(AssertionCredentials)
unless you change the import of  AssertionCredentials?

AppAssertionCredentials is fine.

[Ali Afshar, 2012-08-09 15:10:24]

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py
File oauth2client/gce.py (right):

http://codereview.appspot.com/6441118/diff/1/oauth2client/gce.py#newcode84
oauth2client/gce.py:84: response, content = http_request(uri)
Oh, I see it is tightly coupled to the store. Ok fair enough.

On 2012/08/09 14:59:37, jcgregorio_google wrote:
> _refresh() is defined in the base OAuth2Credentials object and over-ridden
here:
> 
> 
>
http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...
> 
> On 2012/08/09 14:53:40, Ali Afshar wrote:
> > Right, is there no common code with a standard Credentials for performing
this
> > refresh?
> > 
> > On 2012/08/09 14:44:36, jcgregorio_google wrote:
> > > Sorry, I don't understand.This _refresh() will get called as a matter of
> > course
> > > when a Credentials needs refreshing. See
> > >
> >
>
http://code.google.com/p/google-api-python-client/source/browse/oauth2client/...
> > > 
> > > 
> > > On 2012/08/09 14:41:41, Ali Afshar wrote:
> > > > Can this refresh use the existing oauth2 client somehow?
> > > 
> > 
>

[jcgregorio_google, 2012-08-09 18:09:05]

Updated the domain name from 'metadata' to the fully qualified domain name of
'metadata.google.internal'. Also tested on a live server and it works.

[aiuto, 2012-08-09 18:13:48]

lgtm

[jcgregorio_google, 2012-08-09 18:18:30]

On 2012/08/09 18:13:48, aiuto wrote:
> lgtm

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=51f8b6a497b...