Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1082)

Issue 6441106: util/util.h: Replace an include of <iostream> with <ost...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by battre
Modified:
11 years, 7 months ago
Reviewers:
rsc
CC:
rsc1, Dominic Battre, rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

util/util.h: Replace an include of <iostream> with <ostream>. util.h included <iostream> which registers an atexit destructor which slows down the shutdown process. This is not necessary, because only ostreams are used in the code.

Patch Set 1 #

Patch Set 2 : diff -r add9b9a67bf7 https://re2.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/util.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Dominic Battre
Please take a look. I would like to use RE2 in Chrome and have to ...
11 years, 7 months ago (2012-08-06 15:28:13 UTC) #1
rsc
LGTM I will never understand C++. Just for my own curiosity, what does the atexit ...
11 years, 7 months ago (2012-08-09 16:44:53 UTC) #2
rsc
11 years, 7 months ago (2012-08-09 16:46:10 UTC) #3
*** Submitted as http://code.google.com/p/re2/source/detail?r=61789b886064 ***

util/util.h: Replace an include of <iostream> with <ostream>.

util.h included <iostream> which registers an atexit destructor which slows down
the shutdown process. This is not necessary, because only ostreams are used in
the code.

R=rsc, battre, rsc
CC=re2-dev
http://codereview.appspot.com/6441106

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b