Add "/" to rootUrl and service path if not specified

Created to fix the feature request http://code.google.com/p/google-http-java-client/issues/detail?id=145 : Add "/" to end of rootUrl if it is not specified.

[yanivi, 2012-07-31 16:35:32]

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:387:
if (!rootUrl.endsWith("/")) {
I'd prefer to see a reusable static method for normalizing the rootUrl and
serviceUrl.  maybe something roughly like:

  static String normalizeServicePath(String servicePath) {
    if (servicePath.length() == 1) {
      Preconditions.checkArgument(
          "/".equals(servicePath), "service path must equal \"/\" if it is of
length 1.");
      servicePath = "";
    } else if (servicePath.length() > 0) {
      if (!servicePath.endsWith("/")) {
        servicePath += "/";
      }
      if (servicePath.startsWith("/")) {
        servicePath = servicePath.substring(1);
      }
    }
    return servicePath;
  }

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:388:
rootUrl = rootUrl + "/";
please use +=

similarly below

[rmistry, 2012-08-01 12:23:36]

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:387:
if (!rootUrl.endsWith("/")) {
On 2012/07/31 16:35:32, yanivi wrote:
> I'd prefer to see a reusable static method for normalizing the rootUrl and
> serviceUrl.  maybe something roughly like:
> 
>   static String normalizeServicePath(String servicePath) {
>     if (servicePath.length() == 1) {
>       Preconditions.checkArgument(
>           "/".equals(servicePath), "service path must equal \"/\" if it is of
> length 1.");
>       servicePath = "";
>     } else if (servicePath.length() > 0) {
>       if (!servicePath.endsWith("/")) {
>         servicePath += "/";
>       }
>       if (servicePath.startsWith("/")) {
>         servicePath = servicePath.substring(1);
>       }
>     }
>     return servicePath;
>   }

Done.

http://codereview.appspot.com/6441069/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:388:
rootUrl = rootUrl + "/";
On 2012/07/31 16:35:32, yanivi wrote:
> please use +=
> 
> similarly below

Done.

[yanivi, 2012-08-01 15:43:59]

LGTM

http://codereview.appspot.com/6441069/diff/7001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/6441069/diff/7001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:398:
static String normalizeRootUrl(String rootUrl) {
[optional] javadoc
similarly below

[rmistry, 2012-08-01 16:09:26]

http://codereview.appspot.com/6441069/diff/7001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/6441069/diff/7001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:398:
static String normalizeRootUrl(String rootUrl) {
On 2012/08/01 15:43:59, yanivi wrote:
> [optional] javadoc
> similarly below

Done.