Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1608)

Issue 6438046: Use GrMemoryPool with GrCustomStage, add simple reclamation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by TomH
Modified:
11 years, 11 months ago
Reviewers:
bsalomon
CC:
robertphillips, DerekS
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Solves http://code.google.com/p/skia/issues/detail?id=736 by overriding new & delete for GrCustomStage and improving the performance of the memory pool for the access patterns we're seeing.

Patch Set 1 #

Total comments: 2

Patch Set 2 : With TLS, verbal LGTM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M include/gpu/GrCustomStage.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrCustomStage.cpp View 1 2 chunks +26 lines, -0 lines 0 comments Download
M src/gpu/GrMemoryPool.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/GrMemoryPool.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
TomH
Without reclamation, we needed a pool size >> 100 objects to avoid thrashing. With reclamation, ...
11 years, 11 months ago (2012-07-24 19:23:36 UTC) #1
TomH
Extra data point: without this, memory management made createTextureEffect ~ 15% slower on the drawPosText ...
11 years, 11 months ago (2012-07-24 19:24:16 UTC) #2
bsalomon
http://codereview.appspot.com/6438046/diff/1/src/gpu/GrCustomStage.cpp File src/gpu/GrCustomStage.cpp (right): http://codereview.appspot.com/6438046/diff/1/src/gpu/GrCustomStage.cpp#newcode14 src/gpu/GrCustomStage.cpp:14: static GrMemoryPool gStagePool (30 * sizeof(GrCustomStage), 30 * sizeof(GrCustomStage));; ...
11 years, 11 months ago (2012-07-24 20:34:42 UTC) #3
TomH
After discussion: 1. 4k is reasonable 2. also need to remove static initializer and add ...
11 years, 11 months ago (2012-07-24 20:38:32 UTC) #4
TomH
11 years, 11 months ago (2012-07-24 21:36:30 UTC) #5
Committed in r4744 after verbal LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b