Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 6438043: This is an alternative fix to issue 2664. It assigns a "Staff" alias (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dak
Modified:
11 years, 9 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

This is an alternative fix to issue 2664. It assigns a "Staff" alias to FretBoards (which is also reasonable for things like instrumentName, less so for clefs and similar folderol) and generally uses \set Staff.stringTuning instead of \set stringTuning. It could also be applied on top of the other fix on review (of course, with a different result from running update-with-convert-ly.sh committed). The advantage of using this commit alone for a fix is consistent use of Staff.stringTuning. The disadvantage is that conversions to versions between 2.15.10 and 2.15.41 will continue being defective. However, you would still require a post-2.15.41 convert-ly to fix that, and the conversion results would be less consistent, and the conversion rule is more complex. Since it is unlikely that conversion to the middle of the 2.15 range will be so important in future as to make people employ a post-2.15.41 convert-ly for that purpose, I lean towards using this simpler fix on its own. It also catches problems more thoroughly than the previous fix. While it would still do so when used for sweeping after the other fix, we's get a mixture of overrides to Staff.stringTuning, FretBoards.stringTuning and TabStaff.stringTuning. So barring more convincing arguments, I would likely proceed with using just _this_ fix on its own. Commits: Add Staff alias to FretBoards, let convert-ly set Staff.stringTuning Run scripts/auxiliar/update-with-convert-ly.sh

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M Documentation/de/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/included/display-predefined-mandolin-fretboards.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/included/display-predefined-ukulele-fretboards.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/snippets/defining-predefined-fretboards-for-other-instruments.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/context-string-tuning.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M python/convertrules.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Graham Percival
11 years, 9 months ago (2012-07-25 10:25:01 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b