Issue 6437045: Fix memory leak in SkTableColorFilter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6437045: Fix memory leak in SkTableColorFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by TomH

Modified:
11 years, 11 months ago

Reviewers:
twiz1, robertphillips, reed1

CC:
senorblanco

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Needed a destructor to deallocate bitmap. Added SkNEW while I was at it.

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/effects/SkTableColorFilter.cpp	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 5

TomH

Or do either of the other two of you want to rubber-stamp this and get ...

11 years, 11 months ago (2012-07-24 17:15:29 UTC) #2

twiz1

11 years, 11 months ago (2012-07-24 17:45:25 UTC) #5

On 2012/07/24 17:24:36, TomH wrote:
> Closed with r4733

Thanks for catching this, Tom.