Issue 6434046: Gave GrClip an SkClipStack-style iterator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6434046: Gave GrClip an SkClipStack-style iterator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This is just an intermediate step in the replacement of GrClip so I didn't spend a lot of time fleshing out the new iteration capability (esp. skipToTopmost).

Patch Set 1 #

Patch Set 2 : cleaned up a bit #

Patch Set 3 : Renamed startOp -> firstOp #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -91 lines)			Patch
M	include/gpu/GrClip.h	View		2 chunks	+63 lines, -0 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrClip.cpp	View		1 chunk	+92 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 2	22 chunks	+129 lines, -88 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2012/07/23 17:25:57, bsalomon wrote: > On 2012/07/23 15:37:02, robertphillips wrote: > > LGTM actually, ...

11 years, 11 months ago (2012-07-23 17:26:46 UTC) #3

Done.

Committed as r4723.

Expand All Messages | Collapse All Messages