Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6708)

Issue 6432059: Avoid duplication between slur and phrasing slur engravers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dak
Modified:
8 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Avoid duplication between slur and phrasing slur engravers. The original code in slur-engraver.cc contained a comment: This is largely similar to Phrasing_slur_engraver. Check if fixes apply there too. (on principle, engravers don't use inheritance for code sharing) This patch violates that principle. However, it uses neither multiple inheritance nor virtual base classes nor templates for this, but just a common base class with virtual functions.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -383 lines) Patch
D lily/phrasing-slur-engraver.cc View 1 chunk +0 lines, -334 lines 0 comments Download
M lily/slur-engraver.cc View 12 chunks +143 lines, -49 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b