Issue 6428075: Midi; issue 2707

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6428075: Midi; issue 2707 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Keith

Modified:
11 years, 4 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Midi: bugfix in computing (de)crescendo changes Midi: initial volume if a Voice begins in (de)cresc Patchset 1 is the already-pushed fix for midi dynamics. Patches 2 is the final two patches in the set http://lists.gnu.org/archive/html/lilypond-devel/2012-07/msg00441.html The code comments explain the solution; Heikki's email above explains the problem (which is more complicated than the solution).

Patch Set 1 #

Patch Set 2 : Patches from Heikki under tracker issue 2707 #

Patch Set 3 : indicate source line in warning; expect warnings in regtests #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
M	input/regression/morgenlied.ly	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	input/regression/typography-demo.ly	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lily/audio-item.cc	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	lily/dynamic-performer.cc	View	1 2	6 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages