Issue 6425061: Issue 2664: stringTunings snippet in NR 2.4.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6425061: Issue 2664: stringTunings snippet in NR 2.4.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dak

Modified:
11 years, 9 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issue 2664: stringTunings snippet in NR 2.4.1 This fixes an unfortunate convertrule that used \set stringTuning = ... which sets the string tuning in the current Bottom context. Which does not work in a TabStaff. This is followed by the following commits rehashing the convertrule operation: Revert "Run update-with-convert-ly" This reverts commit 0d0a674ba7bfa052e277861427c0a2d7a6d2cdde. Conflicts: Documentation/de/notation/fretted-strings.itely Documentation/es/notation/fretted-strings.itely Rerun update-with-convert-ly When committed, the whole kaboodle will be done as one merge commit. Translators will likely doing their readers a favor by hand-polishing the results of the automatic conversion.

Patch Set 1 #

Patch Set 2 : Fix a few more cases of setting stringTunings without context address #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
M	Documentation/de/notation/fretted-strings.itely	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Documentation/es/notation/fretted-strings.itely	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Documentation/fr/notation/fretted-strings.itely	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/included/display-predefined-mandolin-fretboards.ly	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/included/display-predefined-ukulele-fretboards.ly	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/notation/fretted-strings.itely	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Documentation/snippets/defining-predefined-fretboards-for-other-instruments.ly	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	input/regression/context-string-tuning.ly	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	python/convertrules.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download