Issue 6425052: Unbinding of methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6425052: Unbinding of methods

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by mstefanro

Modified:
12 years, 6 months ago

Reviewers:
Andrew Svetlov

Visibility:
Public.

More Reviews

Description

Unbinding of methods

Patch Set 1 #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -18 lines)			Patch
M	Include/descrobject.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Include/methodobject.h	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	Lib/functools.py	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	Lib/inspect.py	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Lib/test/test_functools.py	View	2 chunks	+56 lines, -0 lines	0 comments	Download
M	Lib/types.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Objects/classobject.c	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	Objects/descrobject.c	View	11 chunks	+32 lines, -8 lines	0 comments	Download
M	Objects/methodobject.c	View	4 chunks	+36 lines, -5 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Andrew Svetlov

12 years, 6 months ago (2012-07-19 20:13:22 UTC) #1

Maybe it's subject for separate issue — but it is good finding.

http://codereview.appspot.com/6425052/diff/1/Objects/classobject.c
File Objects/classobject.c (right):

http://codereview.appspot.com/6425052/diff/1/Objects/classobject.c#newcode248
Objects/classobject.c:248: Py_XDECREF(funcname);
Looks like you found refleak. It should be fixed anyway

Expand All Messages | Collapse All Messages