Issue 6425045: CG: clarify staging branch policy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6425045: CG: clarify staging branch policy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by John Mandereau

Modified:
11 years, 8 months ago

Reviewers:
janek, dak

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

CG: clarify staging branch policy The big paragraph is suggested by David Kastrup in http://lists.gnu.org/archive/html/lilypond-devel/2012-07/msg00472.html

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	Documentation/contributor/administration.itexi	View		1 chunk	+3 lines, -0 lines	2 comments	Download
	M	Documentation/contributor/source-code.itexi	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

Other than that, LGTM. http://codereview.appspot.com/6425045/diff/1/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): http://codereview.appspot.com/6425045/diff/1/Documentation/contributor/administration.itexi#newcode280 Documentation/contributor/administration.itexi:280: @warning{in case the build fails, ...

11 years, 9 months ago (2012-07-18 15:39:36 UTC) #2

John Mandereau

11 years, 9 months ago (2012-07-18 22:31:45 UTC) #3

Pushed to staging after moving the @warning as suggested.

http://codereview.appspot.com/6425045/diff/1/Documentation/contributor/admini...
File Documentation/contributor/administration.itexi (right):

http://codereview.appspot.com/6425045/diff/1/Documentation/contributor/admini...
Documentation/contributor/administration.itexi:280: @warning{in case the build
fails, do not try to push fixes on top of
On 2012/07/18 15:39:36, dak wrote:
> The placement of this warning in the middle of the cron instructions seems a
bit
> weird.  It seems like it belongs either at the end of the section, or
somewhere
> close to where the motivation of staging-patchy is explained.

You're right, I moved it after line 255
"them in a logfile. It also merges @code{staging} into @code{master}."

Expand All Messages | Collapse All Messages