Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6419073: Fix npot bitmap tiling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bsalomon
Modified:
12 years, 3 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/gpu/GrContext.cpp View 2 chunks +1 line, -1 line 1 comment Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 2
bsalomon
Fixes two bugs: The call to get the cached texture needs to see the wrap ...
12 years, 3 months ago (2012-07-24 15:58:37 UTC) #1
TomH
12 years, 3 months ago (2012-07-24 16:28:36 UTC) #2
LGTM.

Even simplifies the code!

http://codereview.appspot.com/6419073/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6419073/diff/1/src/gpu/GrContext.cpp#newcode383
src/gpu/GrContext.cpp:383: drawState->createTextureEffect(0,
clampEntry.texture());
This again? Aargh.

Once we wrap tex parameters into the creation call this should be harder to
screw up.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b