Issue 6419073: Fix npot bitmap tiling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6419073: Fix npot bitmap tiling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bsalomon

Modified:
12 years, 5 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
	M	src/gpu/GrContext.cpp	View		2 chunks	+1 line, -1 line	1 comment	Download
	M	src/gpu/SkGpuDevice.cpp	View		4 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

Fixes two bugs: The call to get the cached texture needs to see the wrap ...

12 years, 5 months ago (2012-07-24 15:58:37 UTC) #1

TomH

12 years, 5 months ago (2012-07-24 16:28:36 UTC) #2

LGTM.

Even simplifies the code!

http://codereview.appspot.com/6419073/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6419073/diff/1/src/gpu/GrContext.cpp#newcode383
src/gpu/GrContext.cpp:383: drawState->createTextureEffect(0,
clampEntry.texture());
This again? Aargh.

Once we wrap tex parameters into the creation call this should be harder to
screw up.

Expand All Messages | Collapse All Messages