Issue 6419054: code review 6419054: re2: fix (?i)\S when using !ClassNL or NeverNL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6419054: code review 6419054: re2: fix (?i)\S when using !ClassNL or NeverNL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rsc

Modified:
11 years, 9 months ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: fix (?i)\S when using !ClassNL or NeverNL The \n was leaking in despite being excluded.

Patch Set 2 : diff -r d383bb2fe3eb https://re2.googlecode.com/hg/ #

Patch Set 3 : diff -r d383bb2fe3eb https://re2.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d383bb2fe3eb https://re2.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -9 lines)			Patch
	M	re2/parse.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	re2/testing/parse_test.cc	View	1 2 3	4 chunks	+66 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg/

11 years, 9 months ago (2012-07-19 22:08:28 UTC) #1

LGTM http://codereview.appspot.com/6419054/diff/5001/re2/testing/parse_test.cc File re2/testing/parse_test.cc (right): http://codereview.appspot.com/6419054/diff/5001/re2/testing/parse_test.cc#newcode150 re2/testing/parse_test.cc:150: // Reported bug. you could say what the ...

11 years, 9 months ago (2012-07-19 22:10:25 UTC) #2

rsc

11 years, 9 months ago (2012-07-19 22:14:27 UTC) #3

*** Submitted as http://code.google.com/p/re2/source/detail?r=add9b9a67bf7 ***

re2: fix (?i)\S when using !ClassNL or NeverNL

The \n was leaking in despite being excluded.

R=r
CC=re2-dev
http://codereview.appspot.com/6419054

Expand All Messages | Collapse All Messages