Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 6413043: code review 6413043: Explicitly cast narrowing conversions in contexts where they (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rsc
Modified:
11 years, 8 months ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

Explicitly cast narrowing conversions in contexts where they will become errors in C++0x. [Exported from internal Google RE2 repository.]

Patch Set 1 #

Patch Set 2 : diff -r addbf62262f7 https://re2.googlecode.com/hg/ #

Patch Set 3 : diff -r addbf62262f7 https://re2.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M re2/testing/re2_arg_test.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2
rsc
Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg/
11 years, 8 months ago (2012-07-17 20:45:13 UTC) #1
rsc
11 years, 8 months ago (2012-07-17 20:45:17 UTC) #2
*** Submitted as http://code.google.com/p/re2/source/detail?r=d383bb2fe3eb ***

Explicitly cast narrowing conversions in contexts where they
will become errors in C++0x.

[Exported from internal Google RE2 repository.]

R=rsc
CC=re2-dev
http://codereview.appspot.com/6413043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b