Issue 6411043: Add skipToLast method to SkClipStack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6411043: Add skipToLast method to SkClipStack (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by robertphillips

Modified:
12 years, 1 month ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

A more strchr-inspired version of http://codereview.appspot.com/6405053/

Patch Set 2 : Added comment #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -4 lines)			Patch
	M	include/core/SkClipStack.h	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
	M	src/core/SkClipStack.cpp	View	1	3 chunks	+42 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm w/ documentation questions http://codereview.appspot.com/6411043/diff/1/include/core/SkClipStack.h File include/core/SkClipStack.h (right): http://codereview.appspot.com/6411043/diff/1/include/core/SkClipStack.h#newcode80 include/core/SkClipStack.h:80: const Clip* prev(); // Moves ...

12 years, 1 month ago (2012-07-17 21:37:04 UTC) #2

robertphillips

12 years, 1 month ago (2012-07-18 12:06:40 UTC) #3

committed as r4644

http://codereview.appspot.com/6411043/diff/1/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

http://codereview.appspot.com/6411043/diff/1/include/core/SkClipStack.h#newco...
include/core/SkClipStack.h:80: const Clip* prev();
On 2012/07/17 21:37:04, reed1 wrote:
> // Moves the iterator to the last clip with the specified RegionOp and returns
> that clip. If no clip with that op is found, returns NULL.

Done.

http://codereview.appspot.com/6411043/diff/1/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

http://codereview.appspot.com/6411043/diff/1/src/core/SkClipStack.cpp#newcode205
src/core/SkClipStack.cpp:205: SkClipStack::Iter::Iter()
Done. The coding standard may need clarification that it is "one initializer per
line" unless it can all fit on one line.

Expand All Messages | Collapse All Messages