Issue 6409048: Fix two sub-optimal iterator uses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6409048: Fix two sub-optimal iterator uses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by robertphillips

Modified:
12 years, 4 months ago

Reviewers:
Steve VanDeBogart, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix two sub-optimal iterator uses 1) replace an over elaborate method of achieving front 2) use new SkClipStack::prev functionality to back up an iterator

Patch Set 2 : Removed unused variable #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	src/core/SkCanvas.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View	1	3 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

reed1

lgtm -- should vandebo review this, or has he already cleared the idea?

12 years, 4 months ago (2012-07-16 19:30:27 UTC) #2

Steve VanDeBogart

http://codereview.appspot.com/6409048/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/6409048/diff/1/src/pdf/SkPDFDevice.cpp#newcode232 src/pdf/SkPDFDevice.cpp:232: int count = 0; count isn't needed any more

12 years, 4 months ago (2012-07-16 20:20:13 UTC) #4

robertphillips

Ooops - nice catch. http://codereview.appspot.com/6409048/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/6409048/diff/1/src/pdf/SkPDFDevice.cpp#newcode232 src/pdf/SkPDFDevice.cpp:232: int count = 0; On ...

12 years, 4 months ago (2012-07-16 20:23:46 UTC) #5

committed as r4633

Expand All Messages | Collapse All Messages