Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 6407049: Factory method for creating GrGLProgram (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bsalomon
Modified:
12 years, 1 month ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -108 lines) Patch
M src/gpu/gl/GrGLProgram.h View 3 chunks +28 lines, -22 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 22 chunks +82 lines, -58 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 4 chunks +6 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGpuGL_unittest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4
bsalomon
Also makes GrGLProgram responsible for deleting its own gl resources.
12 years, 1 month ago (2012-07-17 12:21:32 UTC) #1
TomH
LGTM. Any particular reason to move it to a factory?
12 years, 1 month ago (2012-07-17 13:52:46 UTC) #2
bsalomon
It seemed cleaner for the callers (try creating and check return) and I want to ...
12 years, 1 month ago (2012-07-17 15:14:34 UTC) #3
bsalomon
12 years, 1 month ago (2012-07-18 13:22:48 UTC) #4
Closed with r4646.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b