Move Texture Domains onto a GrCustomStage

[TomH, 2012-07-16 17:38:20]

Going to need reworking to deal with the ProgramData refactor, but works at ToT.

One open question - the old code would reset the stored texture domain if we had
an orientation change. It isn't obvious to me that it was doing this right, or
why it might have been necessary; the current code seems to work fine without
it, but that may be lack of test coverage.

[bsalomon, 2012-07-16 18:52:21]

http://codereview.appspot.com/6405050/diff/2001/src/gpu/effects/GrTextureDoma...
File src/gpu/effects/GrTextureDomainEffect.cpp (right):

http://codereview.appspot.com/6405050/diff/2001/src/gpu/effects/GrTextureDoma...
src/gpu/effects/GrTextureDomainEffect.cpp:36: GrRect      fTextureDomain;
Does this really need a copy of the rect? It isn't updated in setData.

[TomH, 2012-07-16 19:46:00]

No particular performance difference on Linux fishtank when rolled into Chrome.

http://codereview.appspot.com/6405050/diff/2001/src/gpu/effects/GrTextureDoma...
File src/gpu/effects/GrTextureDomainEffect.cpp (right):

http://codereview.appspot.com/6405050/diff/2001/src/gpu/effects/GrTextureDoma...
src/gpu/effects/GrTextureDomainEffect.cpp:36: GrRect      fTextureDomain;
On 2012/07/16 18:52:22, bsalomon wrote:
> Does this really need a copy of the rect? It isn't updated in setData.

Done.

[bsalomon, 2012-07-17 17:09:52]

Shouldn't we also remove everything texture-domain related from GrSamplerState?

http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h
File src/gpu/gl/GrGLProgram.h (left):

http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h#oldc...
src/gpu/gl/GrGLProgram.h:315: // The texture domain and texture matrix sent to
GL depend upon the
Can you update the comment?

[TomH, 2012-07-17 18:17:24]

All signs of texture domain stripped ruthlessly from GrSamplerState, reducing
its size by another quarter or third.

Happily, no GM impact.

http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h
File src/gpu/gl/GrGLProgram.h (left):

http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h#oldc...
src/gpu/gl/GrGLProgram.h:315: // The texture domain and texture matrix sent to
GL depend upon the
On 2012/07/17 17:09:53, bsalomon wrote:
> Can you update the comment?

Done.

[bsalomon, 2012-07-17 18:26:08]

On 2012/07/17 18:17:24, TomH wrote:
> All signs of texture domain stripped ruthlessly from GrSamplerState, reducing
> its size by another quarter or third.
> 
> Happily, no GM impact.
> 

LGTM
> http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h
> File src/gpu/gl/GrGLProgram.h (left):
> 
>
http://codereview.appspot.com/6405050/diff/3008/src/gpu/gl/GrGLProgram.h#oldc...
> src/gpu/gl/GrGLProgram.h:315: // The texture domain and texture matrix sent to
> GL depend upon the
> On 2012/07/17 17:09:53, bsalomon wrote:
> > Can you update the comment?
> 
> Done.

[TomH, 2012-07-17 18:43:44]

Closed with r4641.