Issue 6398056: code review 6398056: Make re2 compile under MSVC.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6398056: code review 6398056: Make re2 compile under MSVC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rsc

Modified:
11 years, 9 months ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

Make re2 compile under MSVC. Adds less than operator and data members in StateHash to let it behave like MSVC hash compare. Does not define RE2::Options::kDefaultMaxMem in re2.cc because it will trigger LNK2005 in MSVC compiler. [Exported from internal Google RE2 repository.]

Patch Set 1 #

Patch Set 2 : diff -r f9d3d0a558f9 https://re2.googlecode.com/hg/ #

Patch Set 3 : diff -r f9d3d0a558f9 https://re2.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	re2/dfa.cc	View	1	3 chunks	+27 lines, -0 lines	0 comments	Download
	M	re2/re2.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg/

11 years, 9 months ago (2012-07-17 20:22:33 UTC) #1

rsc

11 years, 9 months ago (2012-07-17 20:22:37 UTC) #2

*** Submitted as http://code.google.com/p/re2/source/detail?r=8a54ff883c2e ***

Make re2 compile under MSVC.

Adds less than operator and data members in StateHash to let it behave like MSVC
hash compare.
Does not define RE2::Options::kDefaultMaxMem in re2.cc because it will trigger
LNK2005 in MSVC compiler.

[Exported from internal Google RE2 repository.]

R=rsc
CC=re2-dev
http://codereview.appspot.com/6398056

Expand All Messages | Collapse All Messages