Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9745)

Issue 6397054: Add function for overriding broken spanners to LilyPond.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by david.nalesnik
Modified:
11 years, 9 months ago
Reviewers:
janek, thomasmorley65
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add function for overriding broken spanners to LilyPond. The music function \alterBroken is intended to facilitate overrides applied independently to the pieces of broken spanners--one of the perennial difficulties faced by users of LilyPond (addressed in Extending 2.6:"Difficult Tweaks"). The function aims at generalization by allowing the user to specify the name of the spanner and the property to be overridden. The function will override unbroken spanners, but it will ignore non-spanners with a warning. The function calls \override and may be prefaced by \once (or followed by a \revert of the relevant property).

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : delete whitespace just introduced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A input/regression/alter-broken.ly View 1 chunk +45 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +31 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7
david.nalesnik
11 years, 9 months ago (2012-07-17 22:43:35 UTC) #1
janek
On Wed, Jul 18, 2012 at 12:43 AM, <david.nalesnik@gmail.com> wrote: > The function will override ...
11 years, 9 months ago (2012-07-18 05:22:55 UTC) #2
david.nalesnik
Hi Janek, On Wed, Jul 18, 2012 at 12:22 AM, Janek Warchoł <janek.lilypond@gmail.com>wrote: > On ...
11 years, 9 months ago (2012-07-18 11:56:05 UTC) #3
janek
On Wed, Jul 18, 2012 at 1:56 PM, David Nalesnik <david.nalesnik@gmail.com> wrote: > Perhaps this ...
11 years, 9 months ago (2012-07-18 17:50:29 UTC) #4
thomasmorley65
2012/7/18 Janek Warchoł <janek.lilypond@gmail.com>: > On Wed, Jul 18, 2012 at 1:56 PM, David Nalesnik ...
11 years, 9 months ago (2012-07-18 18:18:34 UTC) #5
janek
On Wed, Jul 18, 2012 at 8:18 PM, Thomas Morley <thomasmorley65@googlemail.com> wrote: > 2012/7/18 Janek ...
11 years, 9 months ago (2012-07-18 18:34:38 UTC) #6
david.nalesnik
11 years, 9 months ago (2012-07-20 23:37:48 UTC) #7
> > 2012/7/18 Janek Warchoł <janek.lilypond@gmail.com>:
> >> (however, it would be even more awesome if it was one general function
> >> for all purposes ;) )

Considering this some more, I think it's best at the moment to restrict the
function to spanners.  The expanded function encompassing spanners and breakable
items appears to work just fine with the examples I adapted from Harm's snippet.
 However, I'm concerned about other overridable properties, for example those
made available through the 'break-aligned-interface:
http://www.lilypond.org/doc/v2.15/Documentation/internals/break_002daligned_0...

If this patch proves successful, it could later be enhanced to include  
breakable items after more study.

What do you think?

-David
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b