Issue 6392048: Fix SkNO_RETURN_HINT warnings on lion/clang

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6392048: Fix SkNO_RETURN_HINT warnings on lion/clang (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix SkNO_RETURN_HINT warnings on lion/clang

Patch Set 2 : add comments #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	include/core/SkPostConfig.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/core/SkUtils.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM modulo a nit http://codereview.appspot.com/6392048/diff/1/src/core/SkUtils.cpp File src/core/SkUtils.cpp (right): http://codereview.appspot.com/6392048/diff/1/src/core/SkUtils.cpp#newcode11 src/core/SkUtils.cpp:11: A comment as to why ...

12 years, 2 months ago (2012-07-10 21:47:56 UTC) #2

Closed with r4528.

Expand All Messages | Collapse All Messages