Issue 6382044: Adding sanity checks on restore offsets in SkPicturePlayback::draw

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6382044: Adding sanity checks on restore offsets in SkPicturePlayback::draw (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by junov1

Modified:
12 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/core/SkPicturePlayback.cpp	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 2

junov1

PTAL, This sanity check verifies that restoreOffset always result in the playback skipping forward. Under ...

12 years, 2 months ago (2012-07-09 18:34:33 UTC) #1

reed1

12 years, 2 months ago (2012-07-09 18:38:01 UTC) #2

lgtm

sad that we had to break-the-line with \ in an assert