Issue 6379043: drawsSamePixels for GrCustomStage objects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6379043: drawsSamePixels for GrCustomStage objects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by TomH

Modified:
11 years, 11 months ago

Reviewers:
bsalomon, robertphillips

CC:
rileya

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

As we talked about last week with the Conical 2-point Gradient, isEqual() wasn't consistently implemented. Make the implementations consistent, but (after verbal discussion) don't rename. No gms or unit tests were broken in the preparation of this CL.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Now no there there #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	include/gpu/GrCustomStage.h	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download
	M	src/gpu/effects/GrGradientEffects.cpp	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

robertphillips

LGTM modulo two nits http://codereview.appspot.com/6379043/diff/1/include/gpu/GrCustomStage.h File include/gpu/GrCustomStage.h (right): http://codereview.appspot.com/6379043/diff/1/include/gpu/GrCustomStage.h#newcode55 include/gpu/GrCustomStage.h:55: /** Returns true if the ...

11 years, 11 months ago (2012-07-09 17:37:25 UTC) #2

bsalomon

On 2012/07/09 17:47:39, robertphillips wrote: > LGTM LGTM. The comment change reminds me that we ...

11 years, 11 months ago (2012-07-09 18:00:28 UTC) #5

Closed with r4484.

Expand All Messages | Collapse All Messages