Issue 63790044: Solves #417, #415 and #381

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63790044: Solves #417, #415 and #381

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by shailrishabh

Modified:
10 years, 1 month ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Solves #417, #415 and #381

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	MoinMoin/apps/admin/views.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	MoinMoin/user.py	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

10 years, 1 month ago (2014-02-24 21:46:27 UTC) #1

please one changeset per issue, do not mix up stuff, it just makes review more
complicated.

also, put a comment about why your change is correct.

https://codereview.appspot.com/63790044/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/63790044/diff/1/MoinMoin/user.py#newcode99
MoinMoin/user.py:99: theuser.profile[EMAIL_UNVALIDATED] = email
you were just guessing here, right?

i am also guessing now that it is wrong. :D

Expand All Messages | Collapse All Messages