Enable gcc & clang's format string checking on SkString

Add an SK_PRINTF_LIKE macro, which declares a function to have printf-like semantics, allowing gcc and clang to check the format string against the arguments.  Also define an SK_SIZE_T_SPECIFIER macro so there's a cross-platform way of printing a size_t.

Note:  since the functions on SkString are non-static member functions, the parameters must offset by one in this case to accomodate the "this" argument, which is why they're (2, 3) and not (1, 2).

This turned up a number of bugs; I've fixed the obvious ones, but where I wasn't sure, I left them in.  These are:

../bench/ShaderMaskBench.cpp:55: warning: too many arguments for format

(should we omit the argument, or add it to the format string?)

../tests/MathTest.cpp:202: warning: too few arguments for format

One is missing, but which argument belongs to which format string?

[TomH, 2012-07-09 17:42:30]

LGTM.

+brian in case nit in GrGLProgram really is important

http://codereview.appspot.com/6375043/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

http://codereview.appspot.com/6375043/diff/1/src/gpu/gl/GrGLProgram.cpp#newco...
src/gpu/gl/GrGLProgram.cpp:521:
segments.fHeader.append(GrGetGLSLVersionDecl(gl.binding(),
I think printf() instead of append() was intentional, but not very important.

[bsalomon, 2012-07-09 18:02:38]

http://codereview.appspot.com/6375043/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

http://codereview.appspot.com/6375043/diff/1/src/gpu/gl/GrGLProgram.cpp#newco...
src/gpu/gl/GrGLProgram.cpp:521:
segments.fHeader.append(GrGetGLSLVersionDecl(gl.binding(),
On 2012/07/09 17:42:30, TomH wrote:
> I think printf() instead of append() was intentional, but not very important.

I can't remember whether it was intentional or not. But either way, it feels
safer to call append in case someone later adds header code above this line.

[reed1, 2012-07-09 18:36:13]

http://codereview.appspot.com/6375043/diff/1/include/core/SkPostConfig.h
File include/core/SkPostConfig.h (left):

http://codereview.appspot.com/6375043/diff/1/include/core/SkPostConfig.h#oldc...
include/core/SkPostConfig.h:292: 
We these be indented to show the nested levels of #ifdef

http://codereview.appspot.com/6375043/diff/1/src/utils/SkDumpCanvas.cpp
File src/utils/SkDumpCanvas.cpp (left):

http://codereview.appspot.com/6375043/diff/1/src/utils/SkDumpCanvas.cpp#oldco...
src/utils/SkDumpCanvas.cpp:144: str->printf("\"%.*S\"%s", SkMax32(len, 32),
text,
Not a bug in this CL, but I don't see how this will work either way, since
wchar_t can't both mean 16bit and 32bit.

[Stephen White, 2012-07-09 20:57:44]

Landed in r4485; closing.