Token refresh to work with 'old' GData API

These changes would make oauth2client work seemlessly with "old" GData API, e.g.

  BASE_URL = 'https://picasaweb.google.com/data/feed/api'
  albums_feed = BASE_URL + '/user/default?alt=json&max-results=10'

  http = decorator.http()
  resp, content = http.request(albums_feed, headers={'GData-Version': '2'})

  feed = json.loads(content)['feed']
  for entry in feed['entry']:
    photo_id = entry['gphoto$id']['$t']
    title = entry['title']['$t']
    thumb = entry['media$group']['media$thumbnail'][0]['url']

The difference is in token refresh. GData API would return 403 (forbidden) instead of 401.

[alexv, 2012-07-16 07:50:39]

Joe, is this something worth changing? 
I can provide unit tests If this makes sense.

http://codereview.appspot.com/6373049/diff/1/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6373049/diff/1/oauth2client/client.py#newcode419
oauth2client/client.py:419: if resp.status in [401, 403]:
"old" GData API return 403 here, instead of 401. Making a change similar to this
seems to make oauth2client work with both newer and older API (e.g. Contacts
API, Picasa, ecc) for what concerns token refreshing.

[jcgregorio_google, 2012-07-16 16:01:47]

Yes, this is a good change. Please add unit tests. Thanks!

[alexv, 2012-07-16 16:51:26]

http://codereview.appspot.com/6373049/diff/5001/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6373049/diff/5001/tests/test_oauth2client.py#ne...
tests/test_oauth2client.py:85: for status_code in ['401', '403']:
Not sure if this is a "common practice", otherwise I can split it into different
tests.

[jcgregorio_google, 2012-07-16 20:32:02]

LGTM.

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=bb41188ba8e....

  Thanks!

On 2012/07/16 16:51:26, crhyme wrote:
> http://codereview.appspot.com/6373049/diff/5001/tests/test_oauth2client.py
> File tests/test_oauth2client.py (right):
> 
>
http://codereview.appspot.com/6373049/diff/5001/tests/test_oauth2client.py#ne...
> tests/test_oauth2client.py:85: for status_code in ['401', '403']:
> Not sure if this is a "common practice", otherwise I can split it into
different
> tests.