Issue 6356089: Make GrGLShaderBuilder produce the shader strings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6356089: Make GrGLShaderBuilder produce the shader strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : y #

Total comments: 5

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -272 lines)			Patch
M	src/gpu/gl/GrGLProgram.h	View		1 chunk	+1 line, -13 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1	13 chunks	+172 lines, -253 lines	3 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1 2	6 chunks	+8 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2	3 chunks	+46 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLProgram.cpp#newcode468 src/gpu/gl/GrGLProgram.cpp:468: void print_shader(GrGLint stringCnt, moved from below http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLProgram.cpp#newcode481 src/gpu/gl/GrGLProgram.cpp:481: GrGLuint ...

12 years, 2 months ago (2012-07-11 17:43:05 UTC) #1

TomH

LGTM otherwise http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLShaderBuilder.cpp File src/gpu/gl/GrGLShaderBuilder.cpp (right): http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLShaderBuilder.cpp#newcode228 src/gpu/gl/GrGLShaderBuilder.cpp:228: } break?

12 years, 2 months ago (2012-07-11 17:55:38 UTC) #2

bsalomon

12 years, 2 months ago (2012-07-11 18:12:35 UTC) #3

Committed as r4544.

http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

http://codereview.appspot.com/6356089/diff/4001/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:228: }
On 2012/07/11 17:55:38, TomH wrote:
> break?

Done.

Expand All Messages | Collapse All Messages