Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 6356043: Fixed Resource counting bug in AutoScratchTexture detach mechanism (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Before this fix, whenever a texture was detached and reattached to the texture cache (using AST::detach) it would be double counted in the cache's # of textures and memory usage stats. This would obviously lead to trouble down the road w.r.t. purging and reallocating textures.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/gpu/GrResourceCache.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 1 month ago (2012-06-27 14:52:17 UTC) #1
bsalomon
On 2012/06/27 14:52:17, robertphillips wrote: LGTM
12 years, 1 month ago (2012-06-27 14:58:10 UTC) #2
robertphillips
12 years, 1 month ago (2012-06-27 14:59:41 UTC) #3
committed as r4361
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b