Issue 6355043: Added Inst counting to SkFlattenable-derived classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6355043: Added Inst counting to SkFlattenable-derived classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added Inst counting to SkFlattenable-derived classes

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -1 line)			Patch
M	include/core/SkColorFilter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkColorTable.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkDrawLooper.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkImageFilter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkMaskFilter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkPathEffect.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkRasterizer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkShader.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	include/core/SkShape.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkUnitMapper.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	include/core/SkXfermode.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/effects/SkLayerDrawLooper.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkColorFilter.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkColorTable.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkMaskFilter.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/core/SkPathEffect.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkRasterizer.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkShader.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkShape.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkXfermode.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/effects/SkLayerDrawLooper.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/utils/SkUnitMappers.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

This will hopefully give some insight into the 233 "leaked" flattenables.

12 years ago (2012-06-27 12:00:43 UTC) #1

committed as r4359

Expand All Messages | Collapse All Messages