Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 6354085: Doc: more comprehensive documentation of layout block (2560) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Trevor Daniels
Modified:
11 years, 9 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: more comprehensive documentation of layout block (2560) I've essentially copied the text and examples from Urs' suggestions in issue 2560, just changing the wording here and there to match the style of the NR. As I have not myself checked the stated operation of layout blocks I'd welcome careful consideration of this patch by those familiar with their workings.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -3 lines) Patch
M Documentation/notation/input.itely View 2 chunks +8 lines, -3 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 chunk +97 lines, -0 lines 4 comments Download

Messages

Total messages: 6
dak
http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely#newcode1182 Documentation/notation/spacing.itely:1182: to structure the layout design of sources, and also ...
11 years, 9 months ago (2012-07-07 20:01:43 UTC) #1
Trevor Daniels
http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely#newcode1182 Documentation/notation/spacing.itely:1182: to structure the layout design of sources, and also ...
11 years, 9 months ago (2012-07-07 21:23:43 UTC) #2
Graham Percival
LGTM http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely#newcode1098 Documentation/notation/spacing.itely:1098: If this block: How about a "For example," ...
11 years, 9 months ago (2012-07-08 03:55:58 UTC) #3
Trevor Daniels
http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/6354085/diff/1/Documentation/notation/spacing.itely#newcode1098 Documentation/notation/spacing.itely:1098: If this block: On 2012/07/08 03:55:58, Graham Percival wrote: ...
11 years, 9 months ago (2012-07-08 07:36:50 UTC) #4
Graham Percival
I'm content to take your word for the changes, but our general custom these days ...
11 years, 9 months ago (2012-07-09 04:50:29 UTC) #5
Trevor Daniels
11 years, 9 months ago (2012-07-11 06:59:23 UTC) #6
Patch pushed
73255e50558a62841500aa947ff7cad28636d144
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b